Login | Register
My pages Projects Community openCollabNet

Discussions > issues > [Issue 199] New - FIX import: correctly handle url with spaces

pysvn
Discussion topic

Back to topic list

[Issue 199] New - FIX import: correctly handle url with spaces

Author rherzog
Full name Reinhart Herzog
Date 2015-05-11 07:29:18 PDT
Message http://pysvn.tigris.​org/issues/show_bug.​cgi?id=199
                 Issue #|199
                 Summary|FIX import: correctly handle url with spaces
               Component|pysvn
                 Version|current
                Platform|All
              OS/Version|All
                     URL|
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|PATCH
                Priority|P1
            Subcomponent|extension
             Assigned to|barryscott
             Reported by|rherzog






------- Additional comments from rherzog at tigris dot org Mon May 11 07:29:18 -0700 2015 -------
pysvn.import_ crashes when url (2. argument) contains spaces:
"svn: E235000 in file '...\libsvn_subr\dirent_uri.c' line 2306: Assertion
failed (svn_uri_is_canonical(URL, pool))"

The problem is in pysvn_client_cmd_export.cpp, pysvn_client::cmd_import:
For std::string url the conversion using svnNormalisedIfPath is missing.

Patch:
* insert at beginning of try-block:
    std::string norm_url( svnNormalisedIfPath( url, pool ) );
* use norm_url instead of url in the calls
    svn_client_import[2|3](...)

« Previous message in topic | 1 of 7 | Next message in topic »

Messages

Show all messages in topic

[Issue 199] New - FIX import: correctly handle url with spaces rherzog Reinhart Herzog 2015-05-11 07:29:18 PDT
     [Issue 199] FIX import: correctly handle url with spaces rherzog Reinhart Herzog 2015-05-11 07:30:45 PDT
     [Issue 199] FIX import: correctly handle url with spaces barryscott Barry Scott 2015-05-13 11:34:59 PDT
     [Issue 199] FIX import: correctly handle url with spaces rherzog Reinhart Herzog 2015-05-21 00:33:46 PDT
     [Issue 199] FIX import: correctly handle url with spaces rherzog Reinhart Herzog 2015-09-29 01:39:58 PDT
     [Issue 199] FIX import: correctly handle url with spaces barryscott Barry Scott 2015-09-29 08:51:55 PDT
     [Issue 199] FIX import: correctly handle url with spaces barryscott Barry Scott 2015-10-13 02:09:00 PDT
Messages per page: