Login | Register
My pages Projects Community openCollabNet

Discussions > issues > [Issue 197] New - callback_ssl_server_trust_prompt fails to temporarily accept a certificate

pysvn
Discussion topic

Back to topic list

[Issue 197] New - callback_ssl_server_trust_prompt fails to temporarily accept a certificate

Author snordhausen
Full name Stefan Nordhausen
Date 2015-01-22 01:40:20 PST
Message http://pysvn.tigris.​org/issues/show_bug.​cgi?id=197
                 Issue #|197
                 Summary|callback_ssl​_server_trust_prompt​ fails to temporarily
                        |accept a certificate
               Component|pysvn
                 Version|current
                Platform|All
              OS/Version|All
                     URL|
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P3
            Subcomponent|extension
             Assigned to|barryscott
             Reported by|snordhausen






------- Additional comments from snordhausen at tigris dot org Thu Jan 22 01:40:20 -0800 2015 -------
Hi!

While working with pysvn.Client.callbac​k_ssl_server_trust_p​rompt we noticed that
it is not possible to temporarily accept a certificate. Permanently accepting a
certificate works fine, though.

We tracked the problem down to the file pysvn/Extension/Sour​ce/pysvn_svnenv.cpp
line 295 and applied the following changes:


--- pysvn_svnenv.cpp (revision 1590)
+++ pysvn_svnenv.cpp (working copy)
@@ -292,8 +292,8 @@
     if( accept_permanently )
     {
         new_cred->may_save = 1;
- new_cred->accepted_failures = accepted_failures;
     }
+ new_cred->accepted_failures = accepted_failures;
 
     *cred = new_cred;


This will apply the accepted_failures value even when accept_permanently was not
set. After recompiling, temporarily accepting certificates worked as expected.

« Previous message in topic | 1 of 2 | Next message in topic »

Messages

Show all messages in topic

[Issue 197] New - callback_ssl_server_trust_prompt fails to temporarily accept a certificate snordhausen Stefan Nordhausen 2015-01-22 01:40:20 PST
     [Issue 197] callback_ssl_server_trust_prompt fails to temporarily accept a certificate barryscott Barry Scott 2015-11-06 05:22:54 PST
Messages per page: